fix: pointerUp capture#68
Merged
Merged
Conversation
marguslant0
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a bug testing the drag and drop. Sometimes the ghost would get stuck and the pointerUp event seems to get swallowed.
After several testing attempts, I realized it get stuck when the asset is dropped super fast, still in motion, which is a very common human behaviour. In that case the pointerUp fires on the host page, not inside the iframe, so the finder never received it.
This PR adds host-side pointerUp detection in the SDK: the finder now also listens for the release on the host window, so it catches the drop even on quick, in-motion gestures, which makes the DnD snappy fast and efficient.